Package: balazar3
Version: 0.1-5
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu lucid ubuntu-patch

Hi Vincent,

The balazar3 package currently calls python2.5 from debian/rules for setup,
not python.  This is wrong in a number of ways:

- the package build-depends on python-dev, not on python2.5-dev; python-dev
  is not guaranteed to depend on python2.5, so this command will fail when
  the default python version changes in Debian.
- the package furthermore has a runtime dependency on python2.5 and
  python-cerealizer.  python-cerealizer is *not* guaranteed to provide
  the cerealizer module for python2.5, only for the *current* python
  version; so balazar3-common *as installed on users' systems* will be
  broken as soon as python migrates to 2.6 by default (which should happen
  before the squeeze release).

The below patch from Ubuntu corrects this issue.  I recommend applying it to
the Debian package, as this will become a serious bug once pythonswitches to
2.6 in Debian.

=== modified file 'debian/control'
--- debian/control      2009-07-05 09:30:53 +0000
+++ debian/control      2009-12-27 22:37:24 +0000
@@ -84,7 +84,7 @@
 
 Package: balazar3-common
 Architecture: all
-Depends: python2.5, python-cerealizer, ${misc:Depends}
+Depends: python, python-cerealizer, ${misc:Depends}
 Suggests: python-psyco [i386]
 Description: dungeon adventure game with multiplayer support - common files
  Balazar III is a dungeon adventure game with multiplayer support. As

=== modified file 'debian/rules'
--- debian/rules        2008-11-08 10:22:06 +0000
+++ debian/rules        2009-12-27 22:33:26 +0000
@@ -20,7 +20,7 @@
 $(foreach version,$(VERSIONS), build-stamp-$(version)): build-stamp-%: prepare
        dh_testdir
        (cd build/$(patsubst build-stamp-%,%,$@)  && \
-        python2.5 setup.py build --$(patsubst build-stamp-%,%,$@))
+        python setup.py build --$(patsubst build-stamp-%,%,$@))
        touch $@
 
 install: $(foreach version,$(VERSIONS), install/$(version))
@@ -48,7 +48,7 @@
        dh_testroot
        dh_installdirs
        (cd build/$(patsubst install/%,%,$@) && \
-        python2.5 setup.py install --$(patsubst install/%,%,$@) \
+        python setup.py install --$(patsubst install/%,%,$@) \
               --install-scripts=/usr/games \
               --install-purelib=/usr/share/games 
--install-data=/usr/share/games \
               --root=$(CURDIR)/debian/balazar3-$(patsubst install/%,%,$@))


-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
[email protected]                                     [email protected]



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to