While the "transform" stuff does make the scripts less readable and thus less maintainable, it doesn't cost much in execution, and would not in itself be worth diverging from upstream.
The fact that grub-probe is somewhat broken is in my opinion reason enough to diverge from upstream, if that's what it takes to fix it. This bug is over a year old, and update-grub has been extremely slow for longer than that. I checked the grub-devel mailing list, and Kevin Mitchell reported this there back in July. I didn't see a response.
http://lists.gnu.org/archive/html/grub-devel/2009-07/msg00506.html Felix Zielcke wrote:
or the various "|sed ${transform}" could be eliminated. Just garbage, apparently.)If you don't use an old i386 this `garbage' shouldn't matter at all. If you don't want to have it, the proper fix belongs in autoconf. It's used for these ./configure options, generated by the AC_ARG_PROGRAM autoconf macro: Program names: --program-prefix=PREFIX prepend PREFIX to installed program names --program-suffix=SUFFIX append SUFFIX to installed program names --program-transform-name=PROGRAM run sed PROGRAM on installed program names I know that at least the Fedora GRUB 2 packages uses this. So we just can't remove that feature upstream. And I don't think it's worth to diverge from upstream for this just to save a few CPU cycles.
-- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
