Hi Ferenc, We are currently triaging bugs for open-iscsi.
First of all, thank you for the patch. The patch looks good.
But we might need something more than this for data LUNs that are on other
mount points.
On Wednesday 08 Oct 2008 21:34:59 you wrote:
> Package: open-iscsi
> Version: 2.0.870~rc3-0.1
> Severity: important
> Tags: patch
>
> Hi,
>
> When open-iscsi stop is executed on system shutdown, it invokes the
> stoptargets shell function, which logs out of all targets. This breaks
> systems where root is on iSCSI. I decided to leave the job of killing
> iscsid to sendsigs later in the boot process by
>
> --- open-iscsi.orig 2008-10-08 14:47:16.562492743 +0200
> +++ open-iscsi 2008-10-08 17:36:47.877662527 +0200
> @@ -125,6 +125,10 @@
> }
>
> stop() {
> + if [ -f /etc/iscsi/iscsi.initramfs ]; then
> + log_warning_msg "/etc/iscsi/iscsi.initramfs present, not
> stopping iscsid
> yet" + return 0
> + fi
> stoptargets
> log_daemon_msg "Stopping iSCSI initiator service"
> start-stop-daemon --stop --quiet --pidfile $PIDFILE --signal KILL --exec
> $DAEMON
>
> as that buys me a little more safety, but probably excluding stoptargets
> would be enough.
>
> Actually, I'm tempted to say that open-iscsi stop should NEVER execute
> stoptargets. That would also help upgrades (which currently break all
> live iSCSI mounts).
>
But that will not help trigger a real restart where say, you discovered more
targets and removed the old ones, if you don't do a stoptargets, you won't be
able to logout of those targets.
Comments ??
Regards,
Ritesh
--
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."
signature.asc
Description: This is a digitally signed message part.
