On Fri, Feb 12, 2010 at 11:07:57PM +0100, Raphael Hertzog wrote: > Not any longer (in >= 1.15.5), see commit > a8a51a4a53e923250ccc4bf0c2c040a211991c90 in > dpkg's git repo. > > The problem still exists for Launchpad-Bugs-Fixed. > > > This bug report was originally filed about Ubuntu and it can be found at > > http://launchpad.net/bugs/521168 > > I see a branch here. Why didn't you attach your patch in the Debian bug > report?
I did after the initial bug filing, sorry about that. > Anyway, I suggest changing Dpkg/Vendor/Ubuntu.pm in the same way that I > changed find_closes() in a8a51a4a53e923250ccc4bf0c2c040a211991c90. Feel > free to do the change, test it and send a patch here. Attached is such a patch that I tested and worked well. -- Brian Murray @ubuntu.com
--- scripts/Dpkg/Vendor/Ubuntu.pm 2009-05-21 06:45:45 +0000
+++ scripts/Dpkg/Vendor/Ubuntu.pm 2010-02-12 22:27:15 +0000
@@ -91,14 +91,14 @@
sub find_launchpad_closes {
my ($changes) = @_;
- my @closes = ();
+ my %closes;
while ($changes &&
($changes =~ /lp:\s+\#\d+(?:,\s*\#\d+)*/ig)) {
- push(@closes, $& =~ /\#?\s?(\d+)/g);
+ $closes{$_} = 1 foreach($& =~ /\#?\s?(\d+)/g);
}
- @closes = sort { $a <=> $b } @closes;
+ my @closes = sort { $a <=> $b } keys %closes;
return \...@closes;
}
signature.asc
Description: Digital signature
