tags 568228 patch
thanks

Hello,

On trečiadienis 03 Vasaris 2010 11:55:29 Modestas Vainius wrote:
> Package: dpkg-dev
> Version: 1.15.5.6
> Severity: wishlist
> File: /usr/bin/dpkg-gensymbols
> 
> Hello,
> 
> It would be nice if dpkg-gensymbols had an option to generate a diff if
>  there were new/lost symbols in the symbol file but NOT to fail in that
>  case then. Unfortunately, -c0 does not even try to generate a diff.
>  Imagine a source package building 18 library packages all with arch
>  specific symbol files (using arch tags) and dh_makeshlibs failing on the
>  first "lost" arch specific symbol (very likely yet-to-be marked optional)
>  on the buildds.  Highly inefficient because I would like to get patches
>  for all 18 library packages in the single buildd run.  What about allowing
>  e.g. -c-1 (does not look very nice visually though)?

commit d3c59830b773af9257f7237a377ff8381522e2db
Author: Modestas Vainius <modes...@vainius.eu>
Date:   Tue Feb 16 01:09:02 2010 +0200

    Add -q option to dpkg-gensymbols, -c0 never fails AND shows a diff.

    The rationale behind this change that there should be a way to prevent
    dpkg-gensymbols from failing if there are lost symbols but still show a 
diff at
    the same time (which -c0 would not without this patch).

    Imagine a source package which builds multiple library binary packages that 
are
    prone to arch-specific failures (quite typical for C++). Then dh_makeshlibs 
would
    stop at the first dpkg-gensymbols failure giving only one diff. So it 
should be
    possible to get diffs for all libraries in the single buildd run regardless 
of
    check failures (using -c0). The fact that dpkg-gensymbols will never fail is
    not that important if maintainer is pretty sure that symbols might be lost 
only
    due to e.g. unmarked optional symbols or different mangling on other arches.
    When updating to a new upstream, maintainer can set
    DPKG_GENSYMBOLS_CHECK_LEVEL=1 in the environment to temporary restore 
checks.

 debian/changelog           |    3 +++
 man/dpkg-gensymbols.1      |   19 ++++++++++++-------
 scripts/dpkg-gensymbols.pl |   37 ++++++++++++++++++++++++-------------

The commit has been pushed to the git://git.debian.org/users/modax/dpkg.git
branch 'symbol-files' (on top of other fixes).


-- 
Modestas Vainius <modes...@vainius.eu>

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to