On Thu, Feb 18, 2010 at 5:47 PM, gregor herrmann <gre...@debian.org> wrote:
> On Sat, 30 Jan 2010 12:28:27 +0000, Dennis Sheil wrote:
>
>> The post-installation script of liblicense-dev touches
>> /usr/share/icons/hicolor so as to regenerate GNOME's
>> icon cache.  The hicolor-icon-theme package is not a
>> dependency though so liblicense-dev fails when it is
>> not aready installed.
>>
>> Patch attached.
>
> 1) I don't see how adding hicolor-icon-theme to _Build_-Depends helps
>   at installation time.
> 2) IMO the touch'ing in postinst is not needed; hicolor-icon-theme
>   has a trigger on /usr/share/icons/hicolor anyway. And
>   liblicense-_dev_ doesn't install anything into this directory.
>   (Actually none of the binary packages does.)
>
> I suggest to remove this line from the postinst; but maybe I'm
> missing something ...

Since the /usr/share/icons/hicolor directory is touched,
hicolor-icon-theme needs to be installed for the touch to happen
successfully.  Otherwise the touch fails and thus the installation
fails.  This was the main problem, the installation failed.

Of course, an if statement to check this directory exists before
attempting to touch it will solve the problem as well.  Or if a
trigger exists like you say, the touch can be removed.  The problem is
the postinst touch is touching a directory that may not exist on the
system, thus causing the installation to fail.  If a trigger exists,
and this line which breaks the installation is unnecessary and can be
removed, so much the better.

-- Dennis



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to