On Fri, Mar 5, 2010 at 6:08 PM, Jonathan Nieder <jrnie...@gmail.com> wrote: > > Here are some patches against upstream master that seem to fix this. > I am attaching them rather than sending them as separate messages > since the Debian BTS deals better with that.
Cool, thanks for your work! > > Thoughts? > Jonathan Nieder (3): > radeontool: completely skip early cards with --skip Good catch. ACK. Don't feel shy to rewrite the whole function if you feel like it :) > radeontool: error out for missing control or fb region ACK. But I would drop the comment about the old use of lspci. And maybe use plain "int" for ctrl_region and fb_region to avoid any casting. > radeontool: handle r128 again I don't know how many cards and configurations are possible, maybe an interval like 16-64 could be used? I also thought about adding a check for the is_prefetchable (and !is_IO) flag which AFAICS seems to be on for the control regions. However the flag was not set when I tried to read it out with libpciaccess even though lspci indicates it. I don't know if this is a bug in libpciaccess or if I tried to use it the wrong way. Tormod -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
