On Saturday 06 March 2010 18:51:29 you wrote: > Hello, > > I'm the Debian Developer who packages your neat gimp-dds plugin for > the Debian distribution (http://www.debian.org). I've had a user > complain about 1x1 and possibly 2x2 mipaps not generated correctly; you > can see the bug reports there: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=564111 > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=564113 > > I've had a closer look at it, and it seems that the scale_image_box is > somehow not doing the right thing for the lower limit of the pixel size. > See: if sw = sh = 2 and dw = dh = 1, we have for x = 0, y = 0 (the only > pixel) ix = 1 and iy = 1, which means that the code, which is looking at > ix, iy up to ix+1, iy+1 is looking at a non-existing pixel (2,2). > > I'm unsure how to modify the code, simply using > > iy = (y * sh + sh / 2 - 1) / dh; > > would most probably work excepted when sh is 1 ? > > BTW, in this line > > ix = (x * sw + sh / 2) / dw; > > I guess you mean sw rather than sh, don't you ? > > I hope this helps. > > Many thanks again for making this plugin publicly available; it is > dead useful ! > > The CC address is the (first) bug report's mailing list; if you wish > that your answer is recorded in Debian's bug tracking system, please > keep it in CC. > > Vincent > > PS: I saw you've modified quite a bit the code since the 2.0.7 release > which is the one currently available, but it doesn't seem to me that the > bug is fixed in the current SVN version.
I have just released a new version that should fix this problem. Vincent, you had it nailed! It was an "off-by-one" error. Apologies to all for the delay in responding to this issue. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org