Package: piuparts
Version: 0.38
Severity: normal
Tags: patch

The option 'do-not-verify-signatures' does not work. On one hand, it
requires an argument:

$ sudo piuparts ../foo.deb --do-not-verify-signatures
piuparts: error: --do-not-verify-signatures option requires an argument

On the other hand, debootstrap command fails because has an empty
argument (--keyring):

$ sudo piuparts ../foo.deb --do-not-verify-signatures SOMETHING
...
0m0.0s DEBUG: Starting command: ['debootstrap', '--variant=minbase',
'', 'sid', '/tmp/tmpYAUbsS', 'http://babel.esi.uclm.es/debian/']
0m0.0s DUMP:
I: usage: [OPTION]... <suite> <target> [<mirror> [<script>]]
I: Try debootstrap --help' for more information.
E: You must specify a suite and a target.

0m0.0s ERROR: Command failed (status=1): ['debootstrap',
'--variant=minbase', '', 'sid', '/tmp/tmpYAUbsS',
'http://babel.esi.uclm.es/debian/']
I: usage: [OPTION]... <suite> <target> [<mirror> [<script>]]
I: Try debootstrap --help' for more information.
E: You must specify a suite and a target.
...

I attach a patch which resolve these bugs and the "debian_bundle"
warning.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-trunk-686-bigmem (SMP w/4 CPU cores)
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages piuparts depends on:
ii  apt                        0.7.25.3      Advanced front-end for dpkg
ii  debootstrap                1.0.22        Bootstrap a basic Debian system
ii  lsb-release                3.2-23        Linux Standard Base version report
ii  lsof                       4.81.dfsg.1-1 List open files
ii  python                     2.5.4-9       An interactive high-level object-o
ii  python-debian              0.1.16        Python modules to work with Debian

piuparts recommends no packages.

Versions of packages piuparts suggests:
ii  ghostscript                  8.71~dfsg-3 The GPL Ghostscript PostScript/PDF
pn  python-rpy                   <none>      (no description available)

-- debconf-show failed
--- /usr/sbin/piuparts	2009-12-17 14:26:08.000000000 +0000
+++ /tmp/piuparts	2010-03-22 10:31:45.000000000 +0000
@@ -50,7 +50,7 @@
 import unittest
 import urllib
 import uuid
-from debian_bundle import deb822
+from debian import deb822
 
 
 class Defaults:
@@ -361,6 +361,7 @@
 def run(command, ignore_errors=False):
     """Run an external command and die with error message if it fails."""
     assert type(command) == type([])
+    command = [x for x in command if x] # Delete any empty argument
     logging.debug("Starting command: %s" % command)
     env = os.environ.copy()
     env["LC_ALL"] = "C"
@@ -1794,6 +1795,7 @@
 		      help="Make dpkg use --force-confdev, which lets dpkg always choose the default action when a modified conffile is found. This options will make piuparts ignore errors it was designed to report and therefore should only be used to hide problems in depending packages.")
      
     parser.add_option("--do-not-verify-signatures", default=False,
+                      action='store_true',
                       help="Do not verify signatures from the Release files when running debootstrap.")
 
     parser.add_option("-i", "--ignore", action="append", metavar="FILENAME",

Reply via email to