Apologies for not getting to this sooner.
On Sun, Jul 31, 2005 at 09:07:18PM +0200, Max Vozeler wrote:
> Could you have a look at
> <http://svn.hinterhof.net/viewcvs/loop-aes-source/trunk/debian/README.Debian?view=markup>
> and ideally give me feedback whether it addresses your points, and/or
> which parts could be further improved?
I think it is quite clear, thanks. Just one comment:
> On Sun, Jul 03, 2005 at 12:35:24AM -0700, Andrew Pimlott wrote:
> > Second, I was surprised that I had to install the kernel-source
> > package, but I didn't have to actually rebuild the kernel. Perhaps
> > you could clarify that in the package description and/or
> > README.Debian:
> >
> > Although you must have a full kernel source tree to build the
> > loop-aes driver, it does not patch the kernel, so you don't need
> > to rebuild. The newly build module will load into your old
> > kernel.
>
> Using an unconfigured/uncompiled source tree will work most of the
> time, but is not actually safe or recommended.
>
> The loop-AES Makefile looks at a number of files in the source tree to
> determine build settings, and among them are Makefile and
> include/linux/autoconf.h which do not exist or do not contain correct
> settings in unconfigured trees.
>
> It is in fact strongly recommended to build the kernel one intends to
> use before using it to build loop-AES. I hope this requirement is now
> clearer in the new version of README.Debian. If not perhaps you see a
> possible better wording?
I believe you are talking about a custom kernel here, yes? Because with
the Debian kernel, and using module-assistant as recommended, it is not
necessary to build the kernel. And even with a custom kernel, it is not
necessary to rebuild after installing loop-aes-source. So I would still
add something like this in the first paragraph:
. . . are not sufficient. (However, you will not have to rebuild
your kernel to use the loop-aes module.)
Perhaps that seems obvious in light of the instructions, but personally,
when I see that kernel source is required, I jump to the conclusion that
I will need to rebuild.
> > Third, the instructions for using make-kpkg to build loop-aes are a
> > bit incomplete. If you follow the instructions, when you run
> > make-kpkg, you will get hit with a zillion questions from make
> > oldconfig (or at least I did). Perhaps best would be to get the
> > .config that Debian uses, which can be copied from /boot.
>
> This step (copying /boot/config-$KVERS) and the observation from your
> other mail that --append-to-version is required would be useful to add.
> But - I decided to drop this entire section about building for official
> kernels using make-kpkg in favour of describing how one can use
> module-assistant to the same effect.
I haven't tried it, from what I can read, that sounds like a good way to
go.
Andrew
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
