Quoting Ron (r...@debian.org): > I would query why you felt the need to make this depend on dh>=7 > though? This package doesn't depend on any debhelper features > later than what it already declared, so this only makes it harder > for people who might want to backport it than it otherwise needs > to be, and for no real gain at all... > > Since we're probably going to nuke this one before long, I'm not > overly fussed about it in this case, but as a general rule I'd > consider this an undesirable change for any package of mine that > doesn't need it, and doesn't gain any benefit from it. Do you > have some reason to think otherwise?
Well, as debhelper 7 is in lenny, I don't think this is a big hassle to "modernize" the package a bit. Of course, as you point, the change is not really needed "per se". I actually still do this in order to guarantee to people in the future that someone wanting to work on the package *and then* use "new" features of debhelper can do it without breaking anything. This is more or less why the "old" version of debhelper compatibility levels are declared "obsolete" at some point. Actually, cpad-kernel *was* using level 4, which is considered obsolete as of now. So, the level should have been bumped to 5 at the minimum...and while I'm at it, I prefer bringing it to the compatibility level that's in use now. > In any case, I suspect this assumption is wrong: > > * Bump debhelper compatibility to 7 and move this to debian/compat > > (the rationale previously given in debian/rules doesn't make sense > > for me as there is only one place where this is set). > > This package makes a package from itself. So I suspect you've just > introduced a bug in the generated kernel module package, which won't > have this set in any place, now that you've removed the one place > where it was and the rationale explaining that ;) > > I'm sorry if that wasn't as obvious as it could have been from the > package source, but I think that is also why we have the rationale > of only making the minimum of necessary changes in NMU uploads ;P Hmmm, you're right about this, still. I'll go the conservative way and revert that change...then upload to DELAYED/6-DAY
signature.asc
Description: Digital signature
