On Mon, 19 Apr 2010, Loïc Minier wrote:
> It was never reported so far because it's a common issue in upstream
> build systems as well, and there's an easy workaround in the form of
> binutils-multiarch. dpkg-cross depends on binutils-multiarch.
> However, this means that one has to rebuild binutils-multiarch to
> cross-build for an architecture not supported by binutils-multiarch.
Hum, shouldn't we call $arch-objdump only after having checked its
availability?
Are there packages that can be cross-built without the binutils for the
target host? I guess in theory no (but I don't know all esoteric languages
that we have)... but maybe in practice there might be packages which are
wrongly architecture specific that could be crossbuilt without it
nevertheless. It would be sad to introduce a regression for those just
because we're trying to call something that doesn't exist.
> + open(P, "-|", "$od", "-a", "--", $file)
> + || syserr(_g("cannot fork for %s"), "$od");
quotes not needed around $od
> while (<P>) {
> chomp;
> if (/^\s*\S+:\s*file\s+format\s+(\S+)\s*$/) {
> @@ -89,7 +94,7 @@
> return $format{$file};
> }
> }
> - close(P) or subprocerr(_g("objdump on \`%s'"), $file);
> + close(P) or subprocerr(_g("$od on \`%s'"), $file);
No variable in translated strings (I think we can remove the translation
altogether and only put the command called in the message).
> + open(my $objdump, "-|", "$od", "-w", "-f", "-p", "-T", "-R", $file)
> + || syserr(_g("cannot fork for %s"), "$od");
Same applies here.
Cheers,
--
Raphaël Hertzog
Like what I do? Sponsor me: http://ouaza.com/wp/2010/01/05/5-years-of-freexian/
My Debian goals: http://ouaza.com/wp/2010/01/09/debian-related-goals-for-2010/
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
