Package: grub2
Severity: wishlist
Tags: patch

POSIX command substitution

The following patch updates to use POSIX[1] command substitution $() in
place of backtics (``).

Motivation:

- The $() is recommend by many[2]. E.g it nests easily
- Readability. In high resolution display a "tick" is hard to see. Selected
  font may also make reading the "tick" difficult.
- Keyboards may have the tick key in an unnatural position that makes
  it hard to type. E.g acrobatics is needed with FI-keyboard
  (AltGr+key+Space char)

REFERENCES

[1] POSIX standard IEEE Std 1003.1: 2.6.3 Command Substitution
http://www.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_03

[2]
Bash manual: "...old-style backquote" in section "3.5.4 Command Substitution"
http://www.gnu.org/software/bash/manual/bashref.html#Command-Substitution

BashFAQ: Why is $(...) preferred over `...` (backticks)?
http://mywiki.wooledge.org/BashFAQ/082

Advanced Bash-Scripting Guide: "...The $(...) form has
superseded backticks for command substitution."
http://tldp.org/LDP/abs/html/commandsub.html

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
>From 43628233d0a570eab0539d06cabd0ffe977abed2 Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aa...@cante.net>
Date: Thu, 22 Apr 2010 12:59:36 +0300
Subject: [PATCH] default/grub: Use POSIX command substitution
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Signed-off-by: Jari Aalto <jari.aa...@cante.net>
---
 default/grub |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/default/grub b/default/grub
index db4ca80..b7c580e 100644
--- a/default/grub
+++ b/default/grub
@@ -3,7 +3,7 @@
 
 GRUB_DEFAULT=0
 GRUB_TIMEOUT=5
-GRUB_DISTRIBUTOR=`lsb_release -i -s 2> /dev/null || echo Debian`
+GRUB_DISTRIBUTOR=$(lsb_release -i -s 2> /dev/null || echo Debian)
 GRUB_CMDLINE_LINUX_DEFAULT="quiet"
 GRUB_CMDLINE_LINUX=""
 
-- 
1.7.0

Reply via email to