Jens Seidel wrote:
> On Mon, Apr 26, 2010 at 08:36:12AM -0500, Jonathan Nieder wrote:
>> Yes, I do. Sorry to take so long to get back to you; does this patch help?
>
> Yes, it helped:
>
> $ git svn reset -r13 -p
> Cannot find SVN revision 13
>
> $
Excellent, thanks.
>> diff --git a/git-svn.perl b/git-svn.perl
>> index 2c86ea2..97f3891 100755
>> --- a/git-svn.perl
>> +++ b/git-svn.perl
>> @@ -1185,6 +1185,7 @@ sub cmd_reset {
>> "history\n";
>> }
>> my ($r, $c) = $gs->find_rev_before($target, not $_fetch_parent);
>> + die "Cannot find SVN revision $target\n" unless defined($c);
>
> Here the message ends with \n ...
[...]
>> sub rev_map_set {
>> my ($self, $rev, $commit, $update_ref, $uuid) = @_;
>> + defined $commit or die "missing arg3";
>
> here not.
Though I think the output looks strange, all the git-svn messages seem
to end in \n. I think I’ll leave out this second message since any
future bugs of the same kind would be caught by the next line anyway.
Thanks for the review.
Jonathan
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
