On Sat, May 8, 2010 at 7:30 PM, Dirk Eddelbuettel <e...@debian.org> wrote: > > On 8 May 2010 at 18:42, Scott Howard wrote: > | On Sat, May 8, 2010 at 6:35 PM, Dirk Eddelbuettel <e...@debian.org> wrote: > 15-year Debian Developer, I was unaware of the patching effort.
That's impressive that you're a 15 year old DD! Good luck with the rest of the career. The patch I'm referring to is your patch that you applied: --- rcmdr-1.5-4.orig/inst/etc/linux/Rcmdr.desktop +++ rcmdr-1.5-4/inst/etc/linux/Rcmdr.desktop @@ -4,9 +4,9 @@ Comment[fr]=Environnement graphique pour le logiciel de calcul statistique R Comment[it]=Interfaccia grafica per l'ambiente di calcolo statistico R Comment[de]=Graphische Umgebung fuer das R Programm fuer Statistische Berechnungen -Exec=/usr/lib/R/site-library/Rcmdr/etc/linux/Rcmdr.sh +Exec=sh -c 'R_DEFAULT_PACKAGES="$R_DEFAULT_PACKAGES Rcmdr" R "$@"' Icon=/usr/lib/R/site-library/Rcmdr/etc/linux/Rcmdr.svg Name=R Commander Terminal=true Type=Application -X-KDE-SubstituteUID=false +X-KDE-SubstituteUID=false \ No newline at end of file I assume you applied it according to debian/changelog > > So again, what is "we"? Is this a freedesktop cleanup or something? I was pulling a scientist "we" as in avoiding assigning blame or credit to individuals. To be clear: "The fix works well, but you patched the upstream .desktop file and then install an unpatched .desktop file from debian/." > > Prof John Fox at upstream is pretty responsive and will likely include > patches but I need more context here to 'sell' the patch to hom. The only patch is the one that you already applied, just to the wrong file. My personal preference would be to use source 3.0 (quilt), patch the upstream .desktop file, install the upstream one, and delete the .desktop file in debian/ This reduces the chance of the same bug propagating when they release a new upstream release. The way it is set up now, you have to remember to fix the debian/ .desktop file to reflect their changes when upstream releases the next version. > If memory serves I once received a patch, applied it and sent it upstream. You did, but you did not install the .desktop file that you patched. You patched /inst/etc/linux/Rcmdr.desktop but you install debian/r-cran-rcmdr.desktop > I have now done the former in my sources; the next upload will reflect it. Thanks! -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
