On May/13, Christoph Anton Mitterer wrote: > In case zfs-fuse was disabled via ENABLE_ZFS, the init script is > quite chatty by printing out the whole story why it is not started: > if [ "x$ENABLE_ZFS" != "xyes" ]; then > echo "Not starting $NAME: ENABLE_ZFS is not set to 'yes' in > /etc/default/$NAME" >&2 > return 1 > fi > > Is this really necessary? A sysadmin usually disabled it by intention > and therefore knows what happens, and even if not, such information > belongs to man pages. > > I guess, a simple: ... disabled. > would be enough.
agreed. > btw: Throughout the whole initscript, why are you using an "x" in > things like "x$ENABLE_ZFS" != "xyes"?? As you're having quotes > around, this shouldn't be necessary, even if ENABLE_ZFS is > empty/undefined... and it's quite ugly to read. Not my code originally: I was glad to have that init script written for me, so I modified it as little as I could. I'll look into cleaning it up at some point. Cheers, --Seb -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
