Hi!

On Mon, 2010-06-07 at 10:15:58 +0200, Martin Pitt wrote:
> I updated the test cases to now test for the actually installed files,
> to match the behaviour of the patch now. dpgk -L  is now only checked
> for the "all files installed" case, and considered an implementation
> detail for the filtering cases. Updated patch attached.

Thanks! will test it and commit with the new dpkg changes.

> Unfortunately the upgrade test case fails. It seems that in your
> version of the patch files do not get filtered on upgrade, but stay
> installed. I'll try to have a look, but since you are more familiar
> with the recent modifications, do you have an immediate idea why that
> happens?

Yeah, completely my fault, I skimmed over the code that handles the
removal of old files to be removed on upgrade, and at first sight it
looked like it would handle just fine the removal, as the node does
not have the fnnf_new_inarchive flag (process_archive() around line 688)
after being filtered, but it actually matches as it has the same stat
info as the file on the new list (around line 765-766).

Anyway I've fixed it now, and I'm doing some actual testing on the
upgrade test this time, sorry for the trouble. O:)

thanks,
guillem



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to