Peter Stancek <peter.stan...@sazp.sk> suggested:
>
> ERROR: LogFile not found: /var/log/apache2/web1.access.log
>
> the better output is some kind of warning that file is just empty.

I installed awffull 3.8.2-1.1 on a test system to try some
configurations and it has been whining at me daily ever since:

/etc/cron.daily/awffull:
Running: /etc/awffull/awffull.conf file.
ERROR: Rotated LogFile not found: /var/log/apache2/access.log

This message is emitted not because the apache2 access.log file
doesn't exist, but because it is empty (-s instead of -e). So at first
glance I look at /var/log/apache2/access.log and see it exists and
figure something is broken because my email says it's not found.
Additionally, on the scale of TRACE to FATAL, I do not think the cron
job's skipped attempt to slurp the partial file is an ERROR. Please
consider changing the "Non rotated log file" section (read: attempt to
slurp partial file not implicitly configured) to:

  # check current log, if last log is a rotated logfile
  if [ "${LOGFILE}" != "${NLOGFILE}" ]; then
    # empty ?
    [ -s "${NLOGFILE}" ] || { echo "INFO: Current LogFile empty or
missing: ${NLOGFILE}"; continue; };
    # readable ?
    [ -r "${NLOGFILE}" ] || { echo "WARNING: Current LogFile is not
readable: ${NLOGFILE}"; continue; };

    ${AWFFULL} -c ${i} -Q ${NLOGFILE};
    RET=$?;
  fi;


"Current" could be "Non-rotated", or "Partial", or anything else that
indicates it is not the configured LogFile but one selected by a nice
attempt to additionally parse the active log file.

I'll just go remove the echo statements from the non-rotated log file
part. I've tested the non-rotated invocation by hand and it does
return 1, but it doesn't print any messages either. Another indication
to me that it's not a very strong error to run against an empty log
file. When I run against a missing log file I get awffull's message:
"Error: Can't open log file /your/missing/logfile". Works for me.

Finally, since this bug is just wishlist anyway, I wish I could set a
log level filter and not get emails about anything but ERROR and FATAL
or whatever log levels I configured. I'm no fan of webalizer's all or
nothing output on errors vs warnings in quiet mode. Custom cron files
and |grep to the rescue.

Thanks for your work packaging it,
-- 
Jacob



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to