forwarded 587365 a...@firstfloor.org
thanks

"Patrick J. LoPresti" <lopre...@gmail.com> wrote:

Hi Andi, Patrick,

> (I apologize for submitting this via Debian, but I have been
> completely unable to locate contact information for the upstream
> mcelog maintainer.)

Well, now you have it ;) Though the benefit of also reporting to Debian
is that I can fix the issue quickly in Debian once the bug+fix are
confirmed :)

Bug report below for Andi:

> According to the "Intel® 64 and IA-32 Architectures Software
> DeveloperÂ’s Manual", section 15.9.2.5 (Table 15-13), the "T" (timeout)
> bit has the following interpretation:
>
>  1 = Request timed out
>  0 = Request did not time out
>
> But in mcelog-1.0pre3/p4.c, we have the following function:
>
> static char* get_T_str(__u8 t)
> {
>        static char* T[] = {"Request-timeout", "Request-no-timeout"};
>        if (t >= NELE(T)) {
>                return "UNKNOWN";
>        }
>
>        return T[t];
> }
>
>
> This code is interpreting the bit exactly backwards.  (An
> understandable mistake, since Intel's manual oddly describes the
> meaning of "1" before the meaning of "0".)

JB.

-- 
 Julien BLACHE - Debian & GNU/Linux Developer - <jbla...@debian.org> 
 
 Public key available on <http://www.jblache.org> - KeyID: F5D6 5169 
 GPG Fingerprint : 935A 79F1 C8B3 3521 FD62 7CC7 CD61 4FD7 F5D6 5169 



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to