On Tue, Aug 09, 2005 at 02:22:32PM +0200, Alexander Sack - Debian Bugmail wrote:
> Thanks for the patch. I will include it, but would suggest some improvements.

Yes, and the patch also needs to not have current working directory in
the package source main, as per get-orig-source suggestion in
http://www.debian.org/doc/debian-policy/ch-source.html#s-debianrules

> Nevertheless, maybe we should define the upstream version in an external
> file and add a target that upgrades the package to a user defined upstream
> version. This would include to cp the whole source tree to a directory names
> ${pkgname}-${version} (e.g. cp -r mozilla-thunderbird-1.0.2 to
> mozilla-thunderbird-1.0.6), upgrade the upstream tarball, remove the old
> upstream tarball (e.g. rm
> ${pkgname}-${oldversion}/archives/${sourcetarball-prefix}-${version}-${sourcetarball-postfix}.
> The final steps would be to produce a new orig.tar.gz (tar cvzf 
> ${pkgname}_${uversion}.orig.tar.gz
> ${pkgname}-${version}/archives/) and prepend some boilerplate code to the
> debian/changelog file (e.g. a valid entry, with an initial comment: new
> upstream version ${version}).
> 
> What do you think? 

It's a good idea. I've tried doing it manually bug so far I've failed.
One problem at least is that "clean" debian/rules target wants to do
"dounpatch", which of course fails if the whole build-dir is missing.

(For the other issues, I must re-read the policy and other manuals as
I don't seem to grasp the differences between dpkg-source et al --
a stupid developer error..)

> > The makefile dependencies could be better (i.e. get-orig-source
> > provides dfsg source and build depends on dfsg source etc).
> > 
> please no dependencies. The upgrade tarball is a manual operation and should
> not be done automatically ... in any case.

With dependency I mean "if archives/*dfsg.tar.gz does not exists, create
it through get-orig-source". The end result -- upgrade to new upstream
-- is the same as your suggestion above which I suppose you like better.
:)

-Mikko


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to