On Wed, Jul 28, 2010 at 01:33:23PM +0200, Michael Biebl wrote: > Hi Guido, > > A few comments/suggestions: > - Build-Depends on quilt can/should be dropped. Done.
> - libudev-dev Build-Depends is linux only [linux-any]. > - system-config-printer-udev should be Architecture: linux-any > - hal-cups-utils should probably depend on system-config-printer-udev > [linux-any]. Does system-config-printer have a fallback for non-udev systems? > > What happens to the original hal-cups-utils source package? Does it make sense > to keep it around for non-linux systems? > The general question here is, how to handle kbsd/hurd We could make the transitional hal-cups-utils package [linux-any] too so kfreebsd/hurd can keep the real implementation, if wanted. > - seems debian/control and debian/control.in are out-of-sync I keep on editing debian/control directly. Fixed now. > - long package description of hal-cups-utils: the "." should be indented with > one white space, not two. Copy paste error, fixed. > - changelog: "Conflict on hal-cups-utils since system-config-printer- udev > provides" should probably be > "Conflict with hal-cups-utils since system-config-printer-udev provides" Fixed. > - Should the package be split in GUI + core, i.e. move the GNOME bits in a > system-config-printer-gnome package? > Is system-config-printer-kde actually usable without system-config-printer > installed? If not, it would need a dependency on GNOME bits. It'd like to see this happen but I figure having the current version in experimental will make it easier for the KDE team to figure out which parts they need. We can make the split afterwards. > - I'm not a python packager, but the python bits are installed as > /usr/lib/python2.6/site-packages/cupshelpers/*. > Shouldn't the python-cupsutils package be renamed to python-cupshelpers? Think so. But we can make the renaming with system-config-printer -> sytem-config-printer-gnome in one go. Thanks a lot for your feedback, -- Guido -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org