On Sun, Aug 01, 2010 at 05:25:15PM +0100, Niall Walsh wrote: > Package: nbd-client > Version: 1:2.9.16-2 > Severity: normal > > Hi, > > Sorry to probably inspire another sigh, but the configure_networking > fix has problems so I think the nbd-client.initrd needs another > tweak. > > The nbd-client initrd script now always calls configure_networking > > This means that if you have nbd-client installed your initramfs is > now configuring your network card which (I think) nbd only really > requires if nbdroot is set. The most obvious side effect is that > it can introduce a delay before it succeeds or worse fails. > > If you if have a network device that auto-configures and is > supported by the initramfs you won't have a big problem with this. > If you don't and have to wait 265s to boot it's a real pain though.
Er, quite so. > I think the right answer is for nbd-client.initrd to exit early and > silently if "nbdroot" is not set. Indeed. > In the process of coming to the > patch below I realised another couple of things which this addresses: > > 1) IP as set here would not be seen by configure_networking. > initramfs-tools init will export it though so it would have > probably worked as it was for anyone using it that way anyway. > I think if IP is set here BOOTIF should be also? Another > alternative being to set neither here to leave it up to > whatever calls this script. We don't actually need to set it anymore; that used to be necessary in the past, but configure_networking now parses the kernel command line itself. I just removed the IP= stuff from the initramfs hook. > 2) the ordering of root and nbdroot on the command line mattered, > if root=/dev/nbd* was after nbdroot it would overwrite the 3rd > value of the 3 argument form of nbdroot=*. if it was before > it then nbdroot would ignore root (which I think is fine if > the 3 argument form is given). > A result of this patch is that nbdroot is preferred. Probably better to swap that around. If they disagree, and we set up on whatever nbdroot specifies, we won't boot (because the system tries to mount the root filesystem on a device that isn't connected). If they disagree, and we set up on whatever root specifies, no harm done. I'll do both; thanks. -- The biometric identification system at the gates of the CIA headquarters works because there's a guard with a large gun making sure no one is trying to fool the system. http://www.schneier.com/blog/archives/2009/01/biometrics.html -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
