Hi Arto, Tested your patch, and all pretty seems a lot better. No more multi-spawning of the daemon, no more PID file chainsawing... seems good.
Just two things I noted : - first thing in the "stop" stanza : the 15 seconds timeout to switch from SIGTERM to SIGKILL may be a bit long, especially until the server is patched to send the SIGTERM to its worker thread, but I don't know : maybe it is a Debian guideline or something. I'll leave that up to you to decide : just noting a systematic (at least for now) 15 seconds is a tad long to wait, especially when testing things with the server (did quite a few bcfg2-server restarts when I first tested SSL bi-lateral authentication, and, well, this partly was already because of that I had removed the 5 seconds sleep there was in the old init script... so 15 seconds... : 5 seconds could be sufficient, I guess). - other thing is in the "status" stanza : you make the init script exit with a "3" error code, if the server was not running, which outputs something like : "bcfg2-server is not running invoke-rc.d: initscript bcfg2-server, action "status" failed." the second line of which I am not so sure is useful... basically, you make the init script exit with a non-zero error code, even though it is not the culprit, the bcfg2-server at most being the one : the action "status" did not failed in itself - in that case, it only failed our hopes, mostly. Maybe the status stanza should exit with a "0" code whatever happens, and use a "log_daemon_msg" to signal anything, would you find the need to ? What do you think of these two suggestions ? Oh, by the way : the FAM worker thread seems to end up dying on its own once the server is stopped. I hadn't checked this with my patched init script, but it already did (takes a few dozen seconds), and does it as well with yours. So this zombie doesn't crawl very far once the bcfg2-server is killed, which is a good thing to note. Anyway, thanks for caring this bug, and maintaining bcfg2 in Debian : after testing a bit more, I really felt in love with it (a few gripes, like documentation [already bought the Sage short topics which is rather good, albeit a tad outdated and, well... short], the disappearance of a native agent-mode, XML [still... though I am already trying to craft some XML files through auto-templating]... but, still : IMHO far better than anything else I tried, and I tried pretty much everything else in this domain). Oh, and thanks for ditching the use of the LSB "init-functions", unwrapping the start-stop-daemon from these horrors : highly appreciated :p Farewell. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
