Hey Guido,

> This looks great! The only thing left is to cleanup the patch series to
> not fix bugs introduced earlier in the _same_ patch series. E.g.
> c4f184b which fixes a bug introduced earlier, just merge that. Or
> 02f7a2a which removes parse_changelog_file which got introduced in
> 4f6809de just merge that too - there's no need to have things introduced
> in one patch and removed in a follow up. The patch series should
> represent logical changes not chronological ones. The resulting tree
> will look 100% the same, it's just how we get there.
Ah, I had intended to say in the mail that you might want to squash a
few commits, but it seems I forgot to mention that. I hadn't squashed
them myself mostly to facilitate review.

> I can handle the cleanup but you're probaly faster, just let me know if
> your fed up reworking this.
I'm a bit busy right now, so I'd be grateful if you could just squash
them.

Gr.

Matthijs

Attachment: signature.asc
Description: Digital signature

Reply via email to