Hi Svend, On Tue, Aug 31, 2010 at 11:33:56AM -0700, Svend Sorensen wrote: [..snip..] > There is no way to specify the architecture when running "git-pbuilder > create". If additional arguments were passed to cowbuilder, one could > run "git-pbuilder create --architecture i386" to create an i386 image on > an amd64 system. The attached patch allows this. While I do think this make sense I do wonder if we wouldn't have to encode the architecture in the name of the basepath in your example. Otherwise it wouldn't be possible to have a sid baseimage for amd64 and i386 on the same machine. I see two solutions here: making it possible to override $BASE too or to add a --arch option to git-pbuilder that adds the architecture to $BASE.
Russ any comments? Cheers, -- Guido > From 2a4ef2ec630db5196e457558cccf456ec9f42eef Mon Sep 17 00:00:00 2001 > From: Svend Sorensen <[email protected]> > Date: Tue, 31 Aug 2010 11:23:35 -0700 > Subject: [PATCH] git-pbuilder: Pass arguments to update|create|login to > cowbuilder > > Pass additional aguments to git-pbuilder (update | create | login) to > cowbuilder. For example, this allows setting the architecture by running > "git-pbuilder create --architecture i386". > > diff --git a/git-pbuilder b/git-pbuilder > index afc0f65..913911e 100755 > --- a/git-pbuilder > +++ b/git-pbuilder > @@ -78,7 +78,9 @@ fi > # cowbuilder with the corresponding option under sudo rather than proceeding. > case $1 in > update|create|login) > - sudo cowbuilder --"$1" --basepath "$BASE" --dist "$DIST" $OPTIONS > + ACTION="$1" > + shift > + sudo cowbuilder --"$ACTION" --basepath "$BASE" --dist "$DIST" $OPTIONS > "$@" > exit $? > ;; > esac > @@ -105,7 +107,7 @@ git-pbuilder - Wrapper around pbuilder for > git-buildpackage > > DIST=I<distribution> B<git-pbuilder> I<debbuild-options> > > -DIST=I<distribution> B<git-pbuilder> (update | create | login) > +DIST=I<distribution> B<git-pbuilder> (update | create | login) > I<cowbuilder-options> > > =head1 DESCRIPTION > > @@ -147,7 +149,8 @@ passing parameters through B<git-buildpackage>. > Alternately, B<git-pbuilder> may be called with an argument of C<update>, > C<create>, or C<login>. In this case, it calls B<cowbuilder> using > B<sudo> and passes the corresponding command to B<cowbuilder>, using the > -same logic as above to determine the base directory and distribution. > +same logic as above to determine the base directory and distribution. Any > +arguments are passed as-is to cowbuilder. > > =head1 ENVIRONMENT > > -- > 1.7.1 > -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
