tags 595232 confirmed pending
severity 595232 minor
thanks

On Thu, Sep 2, 2010 at 11:39 AM, martin f krafft <madd...@debian.org> wrote:
> Package: libapache2-mod-musicindex
> Version: 1.3.4-1
> Severity: normal
>
> Since the lenny version, libapache2-mod-musicindex started to print
> random data in the HTTP response's Content-Disposition header. This
> causes problems that should otherwise be fixed too (#529459), but it
> suggests that something might be going wrong in
> libapache2-mod-musicindex.

Although your report doesn't give much information, I dug out a little
bit and figured out the following:

Content-Disposition is correct for tarballs
Content-Disposition is correct for single files streaming
Content-Disposition is incorrect for playlists streaming

Reason:
A patch was added to improve support of buggy IE browser, and it
introduced a new bug (this one) which, for some reason, I didn't
notice earlier as apparently my browser immediately redirects
audio/x-mpegurl Content-Type to my music player.

What happens is that the call to apr_table_setn() doesn't duplicate
strings. When the headers are formed, the content_disposition variable
is no longer available and thus the field is empty (it's interesting
to note this doesn't trigger a segv, while I would have expected one).

Anyway, the following one liner should fix your problem. Can you try
it and confirm that this solves the issue? Alternatively I'm tempted
to simply drop the IE workaround which I could never test myself and
which I don't know whether it's actually helpful at all...

Thanks

T-Bone

-- 
Thibaut VARENE
http://www.parisc-linux.org/~varenet/

Attachment: apr_table_set.diff
Description: Binary data

Reply via email to