Le jeudi 09 septembre 2010 à 22:56 +0200, Josselin Mouette a écrit :
> Le jeudi 09 septembre 2010 à 20:22 +0200, Julien Cristau a écrit :
> > AFAIK all X.org drivers have been fixed up for REPEAT_* handling. I
> > can't speak for fglrx and nvidia though.
>
> TTBOMK the nvidia driver in squeeze doesn’t have such a bug.
To summarize a short IRC discussion I just had with Mike: if most
drivers have been fixed, the solution is to invert the logic of the
patch, and require users with a buggy X11 driver to set the environment
variable.
I’m attaching the corresponding patch proposal.
Sebastian, can you take care of the upload?
Thanks,
--
.''`.
: :' : “You would need to ask a lawyer if you don't know
`. `' that a handshake of course makes a valid contract.”
`- -- J???rg Schilling
Index: cairo/src/cairo-xlib-display.c
===================================================================
--- cairo.orig/src/cairo-xlib-display.c 2010-08-17 05:52:51.868996101 +0200
+++ cairo/src/cairo-xlib-display.c 2010-08-17 05:52:54.692995371 +0200
@@ -66,6 +66,8 @@
static cairo_xlib_display_t *_cairo_xlib_display_list;
+static int buggy_repeat_force = -1;
+
static void
_cairo_xlib_remove_close_display_hook_internal (cairo_xlib_display_t *display,
cairo_xlib_hook_t *hook);
@@ -338,6 +340,17 @@
display->buggy_repeat = TRUE;
}
+ /* XXX workaround; see https://bugzilla.mozilla.org/show_bug.cgi?id=413583 */
+ if (buggy_repeat_force == -1) {
+ if (getenv("MOZ_CAIRO_BUGGY_REPEAT"))
+ buggy_repeat_force = 1;
+ else
+ buggy_repeat_force = 0;
+ }
+
+ if (buggy_repeat_force)
+ display->buggy_repeat = TRUE;
+
display->next = _cairo_xlib_display_list;
_cairo_xlib_display_list = display;
