Hi,

rhatto wrote (13 Jan 2010 19:29:44 GMT) :
> The current version in my branch has all features I can imagine for
> it, except if someone needs some special option set.

As a backupninja maintainer, my main problem with your wget branch is
that it has far too much code duplication with the rsync handler. This
should be abstracted out to e.g. lib/lock.in, lib/mount.in, etc.

As a useful proof of code duplication inefficiency, the wget handler
does not benefit from the recent improvements and bugfixes to lock
files handling in the rsync handler.

Rhatto: please keep on with the great work and tell us when this is
sorted out so that we can merge it in.

(Well, this discussion is starting to be rather a upstream one rather
than purely Debian-related, but we are discussing pre-requisites for
the wget handler to be included in the Debian package, so I guess it
nevertheless fits here.)

Bye,
--
  intrigeri <intrig...@boum.org>
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ 
https://gaffer.ptitcanardnoir.org/intrigeri/otr-fingerprint.asc
  | So what?



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to