On Wed, 27 Oct 2010, Evan Broder wrote:
Ah, yeah sorry - that was simply a typo on my part (my Debian machine
with a working sendbug is different from my Ubuntu machine where I
generate patches)
I figured. No worries.
'Twould be nice if we (Debian) had a web interface for this stuff.
Your patch is kind of excessive -- I don't tthink you really mean to do
this:
+ case "$host" in
+- *-linux-gnu*|*-k*bsd*-gnu*|*-*-gnu*)
++ *-linux-gnu*|*-k*bsd*-gnu*)
But in general I'm kind of struggling to understand this patch format where
there's two nested patches.
The patches aren't in a good format to go upstream. Can you improve them so
they can be? You're changing configure.ac but then also patching configure;
best to just re-run autogen.sh if possible.
I'll take a closer look at this on Monday, but that's my thoughts for now.
Yes, sorry. I was targetting a fix in the packaging, so that debdiff
adds another quilt patch. I've attached a simpler patch that only
makes the configure.ac change. The unnecessary changes are probably
autoconf versioning differences.
*nod*
Will review in more detail on Monday!
