Bug#602042: lsb-base: [PATCH] init-functions -- (local): remove non-used vars. Add non defined vars

[Jari Aalto]

Package: lsb-base
Version: 3.2-23.1
Severity: wishlist
Tags: patch


There are non-used variables in "local" statements. And there are
variables that are used before localized to a function. The patch
fixes those.

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lsb-base depends on:
ii  ncurses-bin               5.7+20100313-4 terminal-related programs and man 
ii  sed                       4.2.1-7        The GNU sed stream editor

lsb-base recommends no packages.

lsb-base suggests no packages.

-- no debconf information

>From 3b767a76eda10d0b7ff37e2cca44deb7a51218e6 Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aa...@cante.net>
Date: Sun, 31 Oct 2010 23:58:54 +0200
Subject: [PATCH] init-functions: (local): remove non-used vars. Add non defined vars
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


Signed-off-by: Jari Aalto <jari.aa...@cante.net>
---
 init-functions |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/init-functions b/init-functions
index 57444b8..2433142 100644
--- a/init-functions
+++ b/init-functions
@@ -28,7 +28,7 @@
 #EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 start_daemon () {
-    local force nice pidfile exec i args
+    local force nice pidfile exec args
     force=0
     nice=0
     pidfile=/dev/null
@@ -60,7 +60,7 @@ start_daemon () {
 }
 
 pidofproc () {
-    local pidfile line i pids= status specified pid
+    local pidfile line status specified pid
     pidfile=
     specified=
     
@@ -107,7 +107,7 @@ pidofproc () {
 
 # start-stop-daemon uses the same algorithm as "pidofproc" above.
 killproc () {
-    local pidfile sig status base i name_param is_term_sig
+    local pidfile sig status base name_param is_term_sig
     pidfile=
     name_param=
     is_term_sig=no
@@ -303,6 +303,7 @@ log_end_msg () {
         return 1
     fi
 
+    local retval
     retval=$1
 
     log_end_msg_pre "$@"
@@ -343,6 +344,7 @@ log_action_cont_msg () {
 }
 
 log_action_end_msg () {
+    local end
     log_action_end_msg_pre "$@"
     if [ -z "${2:-}" ]; then
         end="."
-- 
1.7.2.3