Hi! On Fri, Nov 05, 2010 at 06:06:06PM +0100, Emmanuel Kasper wrote: > Ludo did most of the packaging work, I commited some fix for powerpc. > > Right now the two packages ( mame and mame-tools) are lintian clean > exepct for debian-helper overrides warning and the packaging code is > available from download from: > http://indefero.shaperstudio.com/p/mamedeb/ > > This will build a mame v 0.139 binary ( althoug upstream has just > released 0.140 ) > > We have also a mailing list at http://groups.google.com/group/mamedeb
Ok. My first suggestion is to maybe move all of this to Alioth and upload the packages to mentors.debian.net. If you don't have Alioth accounts, you should apply for one now. In the bug report, others have suggested hosting mame in the games packaging team repository. I think it's a good idea, but it's your call. I don't think the Alioth admins are really happy about creating new groups for just one app, and MAME really fits well in the games repo, while that does not mean you'll lose control over your package. As for the mailing list, you might want to just use the pkg-games-devel list. > A feedback on the packaging is more than welcome ! This is very good! Ludo: I don't know where all the packaging history went. If you've been maintaining mame for years, I don't see why you should be getting rid of your entire debian/changelog. There's nothing bad in doing that, it just doesn't show all the previous work behind the package. You should probably update the package to the newest Standards-Version. I also suggest you convert it to DpkgSource v3, as you're using quilt anyway. If you need help with this, just say! http://wiki.debian.org/Projects/DebSrc3.0 Nitpicks in the control file: Extra newline between source package and mame binary package. Description: - "... is a hardware emulator..." - This package provides the MAME binary..." - Remove the authorship information. That will be available in the copyright file. - No space between a word and : This package provides tools to be used with MAME: In the copyright file, you refer to BSD, GPL and LGPL, but no links to common-licenses. dhdcd.c and others don't have an explicit copyright notice in the header, but a pointer to MAME's website. You should probably tell upstream about this. Why do you put the .desktop and .xpm file in a deep dir inside the debian dir? Why not move them to debian/, and reference those files in mame.install (like you do, but using the longest path ever!) A suggestion: on your sed constructs, use another separator and avoid escaping the slashes: sed -i 's%\( comments\).*%\1;/var/games/mame/comments%' $INIFILE You should not run find -exec chmod on every upgrade. If there are a lot of files in that dir, installation could take ages. Many manual pages need a bit more work ("etc." all over the place!) Finally, as you need to repack the .zip, why not do a .tar.bz2? -- Jordi Mallach Pérez -- Debian developer http://www.debian.org/ jo...@sindominio.net jo...@debian.org http://www.sindominio.net/ GnuPG public key information available at http://oskuro.net/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
