Hello,

Klaus asked me to have a look at this for him. I've attached a patch
which replaces the "kill `ps ax | grep command | ... cut`" commands with
simply "kill $(pidof command)". Untested.

John.
diff -ur 
stopmotion-0.6.2.orig//src/presentation/frontends/qtfrontend/qtfrontend.cpp 
stopmotion-0.6.2/src/presentation/frontends/qtfrontend/qtfrontend.cpp
--- stopmotion-0.6.2.orig//src/presentation/frontends/qtfrontend/qtfrontend.cpp 
2010-12-06 09:44:51.000000000 +0100
+++ stopmotion-0.6.2/src/presentation/frontends/qtfrontend/qtfrontend.cpp       
2010-12-06 09:58:34.000000000 +0100
@@ -236,7 +236,7 @@
        prefs->setPreference("importstartdeamon1", 
                        "vgrabbj -f $IMAGEFILE -d $VIDEODEVICE -b -D 0 -i vga 
-L250");
        prefs->setPreference("importstopdeamon1", 
-                       "kill -9 `ps ax | grep vgrabbj | grep -v grep | cut -b 
0-5`");
+                       "kill $(pidof vgrabbj)");
        
        // Default import option 3
        prefs->setPreference("importname2", 
tr("dvgrab").toLatin1().constData());
@@ -246,7 +246,7 @@
                        "dvgrab --format jpeg --jpeg-overwrite 
--jpeg-deinterlace --jpeg-width 640 " 
                        "--jpeg-height 480 --frames 25 $IMAGEFILE");
        prefs->setPreference("importstopdeamon2", 
-                       "kill -9 `ps ax | grep dvgrab | grep -v grep | cut -b 
0-5`");
+                       "kill $(pidof dvgrab)");
        
        // Default import option 4
        prefs->setPreference("importname3", tr("videodog 
singleshot").toLatin1().constData());
@@ -264,7 +264,7 @@
                        "dvgrab --format jpeg --jpeg-overwrite 
--jpeg-deinterlace --jpeg-width 640 "
                        "--jpeg-height 480 --every 25 $IMAGEFILE &");
        prefs->setPreference("importstopdeamon4", 
-                       "kill -9 `ps ax | grep dvgrab | grep -v grep | cut -b 
0-5`");
+                       "kill $(pidof dvgrab)");
        // 
-----------------------------------------------------------------------
 
        // Default export options 
------------------------------------------------

Reply via email to