Package: grub-pc
Version: 1.98+20100804-11
Severity: wishlist
Tags: patch

With the changes of bug#605705, the background can be overwritten using
GRUB_BACKGROUND in /etc/default/grub, but changing the colors of the
menu is not possible. Depending on the background, the default colors
black/black and magenta/black might not be a good choice. My suggestion
is to also allow to override color_normal and color_highlight from
/etc/default/grub.

The attached patch does this in a way that allows overriding in all use
cases, even with a default or theme background picture. It introduces
the GRUB_BACKGROUND_COLOR_NORMAL and GRUB_BACKGROUND_COLOR_HIGHLIGHT
overrides that can be set in /etc/default/grub.

An alternative would be to use the override only if GRUB_BACKGROUND is
set. In that case, the parameters should be added to the
set_background_image "${GRUB_BACKGROUND}" line at the end.

Cheers,

Udo
--- etc/grub.d/05_debian_theme.bak	2010-12-29 17:04:37.000000000 +0100
+++ etc/grub.d/05_debian_theme	2010-12-29 17:07:10.000000000 +0100
@@ -92,8 +92,8 @@
 	# If loading the background image fails, use the default theme.
 	echo "insmod ${reader}"
 	echo "if background_image `make_system_path_relative_to_its_root "${1}"`; then"
-	echo "  set color_normal=${2:-black/black}"
-	echo "  set color_highlight=${3:-magenta/black}"
+	echo "  set color_normal=${GRUB_BACKGROUND_COLOR_NORMAL:-${2:-black/black}}"
+	echo "  set color_highlight=${GRUB_BACKGROUND_COLOR_HIGHLIGHT:-${3:-magenta/black}}"
 	echo "else"
 	set_default_theme "  "
 	echo "fi"

Reply via email to