Release Team,

It has just recently been reported that the shorewall-lite package in
testing (and likewise, the shorewall6-lite package in testing) contains
a bug which renders the package largely unusable.  The associated bugs,
are #610314 (shorewall-lite) and #610327 (shorewall6-lite) and are
severity grave.

I am seeking approval from the release team to prepare an upload to
t-p-u that will correct those two bugs as well as another issue which is
important, but requires only a trivial change to fix.  Please see below
for details.

The diff to fix the init script problem is this:

--- a/Shorewall-lite/init.debian.sh
+++ b/Shorewall-lite/init.debian.sh
@@ -17,10 +17,9 @@ SRWL=/sbin/shorewall-lite
 SRWL_OPTS="-tvv"
 test -n ${INITLOG:=/var/log/shorewall-lite-init.log}
 
-[ "$INITLOG" eq "/dev/null" && SHOREWALL_INIT_SCRIPT=1 || 
SHOREWALL_INIT_SCRIPT=0
+[ "$INITLOG" = "/dev/null" ] && SHOREWALL_INIT_SCRIPT=1 || 
SHOREWALL_INIT_SCRIPT=0
 
 export SHOREWALL_INIT_SCRIPT
-
 test -x $SRWL || exit 0
 test -x $WAIT_FOR_IFUP || exit 0
 test -n "$INITLOG" || {

It will need to be applied once to each package.

Additionally, the main upstream developer has brought to my attention
that there is a rather annoying bug (it would be severity important if a
proper bug report were submitted on it) that prevents some logging
functionality from working.  The diff for that fix is:

--- a/Shorewall-lite/shorewall-lite
+++ b/Shorewall-lite/shorewall-lite
@@ -94,9 +94,9 @@ get_config() {
     [ -z "$LOGFILE" ] && LOGFILE=/var/log/messages
 
     if ( ps ax 2> /dev/null | grep -v grep |  qt grep 'syslogd.*-C' ) ; then
-       LOGREAD="logread | tac"
+       g_logread="logread | tac"
     elif [ -r $LOGFILE ]; then
-       LOGREAD="tac $LOGFILE"
+       g_logread="tac $LOGFILE"
     else
        echo "LOGFILE ($LOGFILE) does not exist!" >&2
        exit 2
@@ -469,6 +469,7 @@ g_use_verbosity=
 g_noroutes=
 g_timestamp=
 g_recovering=
+g_logread=
 
 finished=0
 

As with the first fix, this would have to be applied once to each of
shorewall-lite and shorewall6-lite.  As I will be updating to correct
the two RC bugs, I'd also like permission to include this additional
fix.

Regards,

-Roberto

-- 
Roberto C. Sánchez
http://people.connexer.com/~roberto
http://www.connexer.com

Attachment: signature.asc
Description: Digital signature

Reply via email to