2011/1/24 Harald Jenny <har...@a-little-linux-box.at>:
> On Mon, Jan 24, 2011 at 08:59:41PM +0200, Teodor MICU wrote:
>> 2011/1/24 Harald Jenny <har...@a-little-linux-box.at>:
>> > Ok although the PIDFILE line can be removed with the below code.
>>
>> I'm don't see where PIDFILE is removed.
>
> Just take a look at the next patch version.

I can only spot some cosmetic issues, otherwise I see no problem. The
change USER -> SYSTEMUSER only makes the diff larger and not really
necessary.
It was a good idea to get the 'dirname' out on their own, it is
cleaner like this.

>> I was wrong here. MILTERSOCKET can be empty in the config from
>> /etc/default/$NAME and this should be the default.
>
> Yes but if it's empty the default value is a unix socket.

Ok.

>> I think the above test is always false if you correctly initialize
>> MILTERSOCKET after the /etc/default/$NAME has been sourced.
>> [ -z "$MILTERSOCKET" ] || MILTERSOCKET="/var/lib/amavis/amavisd-milter.sock"
>
> True but I only want to append to OPTIONS when the default values are
> overriden because this keeps the command line shorter :-).

Ok, I see how MILTERSOCKET is used now.

>> Later on you don't check if it's empty but only the type: unix vs inet.
>
> Well seems to me this is just a change in the code flow...

Yes.

The release team will check too, maybe we missed something. :)

Thanks



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to