Bug#323254: dhcp3-client: dhclient-script should not disturb other protocols on interfaces

[Samuel Thibault]

Hi,

Here is an updated patch. Please consider applying it, and from now on
always check that neither of the following commands return anything:

# check for non inet-only configuration
grep ifconfig /etc/dhcp3/dhclient-script | grep -ve '\<inet\>'

# dhclient should never put an interface down, since other protocols may
# be running on it.
grep ifconfig /etc/dhcp3/dhclient-script | grep down

Regards,
Samuel

--- dhclient-script-orig        2005-08-27 09:15:16.000000000 +0200
+++ dhclient-script     2005-08-28 13:53:35.000000000 +0200
@@ -129,7 +129,7 @@
             # Bring down alias interface. Its routes will disappear too.
             ifconfig $interface:0- inet 0
         fi
-        ifconfig $interface 0 up
+        ifconfig $interface inet 0 up
 
         # We need to give the kernel some time to get the interface up.
         sleep 1
@@ -148,7 +148,7 @@
              "$old_ip_address" != "$new_ip_address" ]; then
             # IP address changed. Bringing down the interface will delete all 
routes,
             # and clear the ARP cache.
-            ifconfig $interface inet 0 down
+            ifconfig $interface inet 0
 
         fi
 
@@ -182,7 +182,7 @@
 
         if [ -n "$old_ip_address" ]; then
             # Shut down interface, which will delete routes and clear arp 
cache.
-            ifconfig $interface inet 0 down
+            ifconfig $interface inet 0
         fi
 
         if [ -n "$alias_ip_address" ]; then
@@ -363,7 +363,7 @@
             # Bring down alias interface. Its routes will disappear too.
             ifconfig $interface:0- inet 0
         fi
-        ifconfig $interface 0 up
+        ifconfig $interface inet 0 up
 
         # We need to give the kernel some time to get the interface up.
         sleep 1
@@ -382,7 +382,7 @@
              "$old_ip_address" != "$new_ip_address" ]; then
             # IP address changed. Bringing down the interface will delete all 
routes,
             # and clear the ARP cache.
-            ifconfig $interface inet 0 down
+            ifconfig $interface inet 0
 
         fi
 
@@ -416,7 +416,7 @@
 
         if [ -n "$old_ip_address" ]; then
             # Shut down interface, which will delete routes and clear arp 
cache.
-            ifconfig $interface inet 0 down
+            ifconfig $interface inet 0
         fi
 
         if [ -n "$alias_ip_address" ]; then
@@ -597,7 +597,7 @@
             # Bring down alias interface. Its routes will disappear too.
             ifconfig $interface:0- inet 0
         fi
-        ifconfig $interface 0 up
+        ifconfig $interface inet 0 up
 
         # We need to give the kernel some time to get the interface up.
         sleep 1
@@ -616,7 +616,7 @@
              "$old_ip_address" != "$new_ip_address" ]; then
             # IP address changed. Bringing down the interface will delete all 
routes,
             # and clear the ARP cache.
-            ifconfig $interface inet 0 down
+            ifconfig $interface inet 0
 
         fi
 
@@ -650,7 +650,7 @@
 
         if [ -n "$old_ip_address" ]; then
             # Shut down interface, which will delete routes and clear arp 
cache.
-            ifconfig $interface inet 0 down
+            ifconfig $interface inet 0
         fi
 
         if [ -n "$alias_ip_address" ]; then