Am 01.02.2011 16:30, schrieb Michael Prokop:
Package: glusterfs-server
Version: 3.1.2-1
Severity: important


Quoting /etc/init.d/glusterfs-server:

|  start)
|        [ "$VERBOSE" != no ]&&  log_daemon_msg "Starting $DESC" "$NAME"
|        do_start
|        case "$?" in
|                0|1) [ "$VERBOSE" != no ]&&  log_end_msg 0 ;;
|                2) [ "$VERBOSE" != no ]&&  log_end_msg 1 ;;
|        esac
|        ;;

This happily eats return codes:

+ start-stop-daemon --start --quiet --pidfile /var/run/glusterfsd.pid --exec 
/usr/sbin/glusterfsd -- -p /var/run/glusterfsd.pid -f 
/etc/glusterfs/glusterfsd.vol --log-file /var/log/glusterfs/glusterfsd.vol.log
+ return 2
+ case "$?" in
+ '[' no '!=' no ']'
+ :

Iff VERBOSE=yes is set then it at least says "Starting GlusterFS
server: glusterfsd failed!" but still returns with exit code 0,
whereas on VERBOSE=no it doesn't output anything at all (and returns
with 0 in case of errors with return code 2 of start-stop-daemon as
well).

I'm not sure whether the usage of VERBOSE is adequately used here at
all, but the init script clearly lacks the according "exit $?" in
its case branches.

Hm I don't know if those lines are useable at all @ glusterfsd, since it will fail to start in the default configuration. Also most packages don't use such verbose, return, etc foo values in their init scripts..



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to