Package: gnome-photo-printer
Version: 0.6.5-1
Severity: important
Tags: patch

Our automated buildd log filter[1] detected a problem[2] that will cause
your package to segfault on architectures where the size of a pointer is
greater than the size of an integer, such as ia64.

[1]http://people.debian.org/~dannf/check-implicit-pointer-functions
[2]
Function `gnome_print_job_preview_new' implicitly converted to pointer at 
gpp_callbacks.c:230
Function `gnome_printer_selector_new' implicitly converted to pointer at 
gpp_widget.c:178
Function `gnome_paper_selector_new' implicitly converted to pointer at 
gpp_widget.c:184

The following patch fixes the first and last of these errors.  However,
the second issue isn't trivially fixed because the libgnomeprintui build
does not include the gnome-printer-selector.h file in the
libgnomeprintui-dev package.  You could work around this by copying the
gnome_printer_selector_new() into gpp_widget.c, but it'd probably be
best to work with the libgnomeprintui maintainer to see if dropping that
file is intentional or just an oversight.

diff -urN gnome-photo-printer-0.6.5.orig/src/gpp_callbacks.c 
gnome-photo-printer-0.6.5/src/gpp_callbacks.c
--- gnome-photo-printer-0.6.5.orig/src/gpp_callbacks.c  2004-11-14 
06:01:27.000000000 -0700
+++ gnome-photo-printer-0.6.5/src/gpp_callbacks.c       2005-08-28 
02:42:45.000000000 -0600
@@ -26,6 +26,7 @@
 #include <libgnomeprint/gnome-print.h>
 #include <libgnomeprint/gnome-print-job.h>
 #include <libgnomeprintui/gnome-print-dialog.h>
+#include <libgnomeprintui/gnome-print-job-preview.h>
 #include "gpp_print.h"
 #include "gpp_functions.h"
 #include "gpp_widget.h"
diff -urN gnome-photo-printer-0.6.5.orig/src/gpp_widget.c 
gnome-photo-printer-0.6.5/src/gpp_widget.c
--- gnome-photo-printer-0.6.5.orig/src/gpp_widget.c     2005-01-02 
13:21:09.000000000 -0700
+++ gnome-photo-printer-0.6.5/src/gpp_widget.c  2005-08-28 02:45:50.000000000 
-0600
@@ -26,6 +26,7 @@
 #include <libgnomeprint/gnome-print.h>
 #include <libgnomeprint/gnome-print-job.h>
 #include <libgnomeprintui/gnome-print-dialog.h>
+#include <libgnomeprintui/gnome-print-paper-selector.h>
 #include "gpp_print.h"
 #include "gpp_functions.h"
 #include "gpp_widget.h"

-- 
dann frazier <[EMAIL PROTECTED]>



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to