On Wed, Feb 09, 2011 at 12:56:45AM +0000, Colin Watson wrote:
> The following patch fixes this.  (There are other bashisms in the
> package, but they're in shell scripts that are #! /bin/bash, so that's
> OK.)

It turns out to be slightly more complicated than that.  That patch is
still useful because it means all targets work reliably when /bin/sh is
not bash, but quilt patches aren't necessarily applied on entry to the
clean target.  Until such time as my previous patch is applied in a new
upstream tarball, this further patch is needed:

  * Run clean target with SHELL=/bin/bash, since quilt patches may not be
    applied.

=== modified file 'debian/rules'
--- debian/rules        2008-02-05 15:40:05 +0000
+++ debian/rules        2011-02-09 12:19:02 +0000
@@ -26,7 +26,7 @@ build-stamp:
 clean:
        dh_testdir
        dh_testroot
-       [ ! -f Makefile ] || $(MAKE) clean
+       [ ! -f Makefile ] || $(MAKE) clean SHELL=/bin/bash
        QUILT_PATCHES=debian/patches quilt pop -a -R || test $$? = 2
        rm -rf .pc
        rm -f build-stamp

>   * Fix source package build when /bin/sh is bash.

Also, this should have read "is not bash", of course.

Thanks,

-- 
Colin Watson                                       [cjwat...@debian.org]



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to