Hi Kel!

Am 07.03.2011 11:47, schrieb Kel Modderman:

> A source package is available at:
> http://mentors.debian.net/debian/pool/main/w/wpasupplicant/wpasupplicant_0.7.3-1.dsc
> 
> It contains a bunch of experimental appropriate changes including the cherry
> pick you want. Some of the new changes need a bit of testing and feedback.
> 
> Could you please consider review and upload of it?

I did some basic testing using it via NetworkManager and the package works fine
so far. I didn't test any of the wpa ifupdown hooks / roaming mode or the new
libpcsc dlopen.

Regarding the packaging, there are some smaller points:

1/ You use debhelper compat level 8, so you *need* to build depend on debhelper
(>> 8). Given that squeeze has debhelper 8 and even lenny has a debhelper 8
backport, there should be no problem bumping it.
2/ For b-deps like libnl-dev, you can use the new syntax
libnl-dev [linux-any]
That makes it more readable imho.
3/ Does wpagui work with wpasupplicant (>= 0.6.2) or should that be bumped to
something 0.7.x like?
4/ Why do you need an explicit Depends on libqt4-svg? Does dh_shlibs not
generate an appropriate dep?

Otherwise it looks fine to me and I'd be happy to sponsor the upload.
Can you address the above issues (1/ one is a must, the other I'll leave to your
judgement) and let me know.
Should I wait until you get an ACK from the pcscd maintainer regarding the
dlopen patch?

Cheers,
Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to