On 2011-04-18 22:58, Ludovico Cavedon wrote: | On 01/-10/-28163 11:59 AM, jaalto wrote: | > /etc/default/ntop reads: | > | > # This file will normally include the debconf template but you can disable | > # that and use this file only. | > | > . /var/lib/ntop/init.cfg | > #GETOPT="" | > | > The variables that can be set are not mentioned. | > | > SUGGESTION | > | > Please make it read: | > | > # This file will normally include the debconf template but you can disable | > # that and use this file only. | > . /var/lib/ntop/init.cfg | > # GETOPT="" | > + # USER="ntop" | > + # INTERFACES="eth0" | | I gave this problem some thinking: | -having the same options in 2 places is wrong: the admin should not be | able to just override the values set via debconf | -we do not want the admin to be change the USER variable by hand, | because permission needs to be fixed if that variable is changed | -variables set via debconf (USER, INTERFACES) should not be in a | conffile, while variables not set via debconf (GETOPT) should be in a | conffile. Therefore they cannot be all in the /etc/default/ntop. | | So I believe a solution is | -no longer include /var/lib/ntop/init.cfg from /etc/default/ntop, and | use the latter only for the GETOPT (and ENABLED) options | -include /var/lib/ntop/init.cfg directly from the init script
I agree. Please also add comment to the beginning of /etc/default/ntop # NOTE: to configure more variables, run dpkg-reconfiggure --priority=low ntop Jari -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
