Bug#624685: vclt-tools: Use Digest::SHA and drop Depends on libdigest-sha1-perl

[Salvatore Bonaccorso]

Package: vclt-tools
Version: 0.1.0-1
Severity: normal
Tags: patch
User: debian-p...@lists.debian.org
Usertags: digest-sha-perl-transition 


Hi

We from the Debian Perl Group would like to drop libdigest-sha1-perl
at some point, see [1]. Most of the functionality (except
sha1_transform) of Digest::SHA1 is also provided by Digest::SHA.
Switching from Digest::SHA1 to Digest::SHA should be in principle as
easy as substituting the use of Digest::SHA1 with Digest::SHA.

Digest::SHA is in Perl core since version 5.9.3 and thus is in
Debian's perl since Lenny.

Changing use of Digest::SHA1 to Digest::SHA would thus reduce external
dependencies by one.

 [1] http://deb.li/digestsha

Both bin/sc2vclt and bin/xiph2vclt use Digest::SHA1 qw(sha1). But the
very same functionality is provided by Digest::SHA. Changing the use
of Digest::SHA1 to Digest::SHA will thus allow to drop the Depends on
libdigest-sha1-perl.

Could you plase change this (and too apply upstream)?

Thanks for your work!

Bests,
Salvatore

-- System Information:
Debian Release: 6.0.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -urN vclt-tools-0.1.0.orig//bin/sc2vclt vclt-tools-0.1.0/bin/sc2vclt
--- vclt-tools-0.1.0.orig//bin/sc2vclt	2010-11-17 02:12:38.000000000 +0100
+++ vclt-tools-0.1.0/bin/sc2vclt	2011-04-30 18:15:55.361251944 +0200
@@ -20,7 +20,7 @@
 use XML::Simple;
 use Data::Dumper;
 use LWP::Simple;
-use Digest::SHA1 qw(sha1);
+use Digest::SHA qw(sha1);
 
 $SIG{'ALRM'} = 'IGNORE';
 
diff -urN vclt-tools-0.1.0.orig//bin/xiph2vclt vclt-tools-0.1.0/bin/xiph2vclt
--- vclt-tools-0.1.0.orig//bin/xiph2vclt	2010-11-17 02:12:38.000000000 +0100
+++ vclt-tools-0.1.0/bin/xiph2vclt	2011-04-30 18:16:07.681224400 +0200
@@ -19,7 +19,7 @@
 use strict;
 use XML::Simple;
 use Data::Dumper;
-use Digest::SHA1 qw(sha1);
+use Digest::SHA qw(sha1);
 
 my %mine2codec = (
                   'application/ogg' => 'ogg_vorbis',