Source: syslinux
Version: 2:4.03+dfsg-12
Severity: normal
Tags: patch
Hi
We from the Debian Perl Group would like to drop libdigest-sha1-perl
at some point, see [1]. Most of the functionality (except
sha1_transform) of Digest::SHA1 is also provided by Digest::SHA.
Switching from Digest::SHA1 to Digest::SHA should be in principle as
easy as substituting the use of Digest::SHA1 with Digest::SHA.
Digest::SHA is in Perl core since version 5.9.3 and thus is in
Debian's perl since Lenny.
Changing use of Digest::SHA1 to Digest::SHA would thus reduce external
dependencies by one.
[1] http://deb.li/digestsha
syslinux ships sha1pass, which uses Digest::SHA1. Could you patch it
(and forward upstream) to use Digest::SHA instead which will allow to
drop the libdigest-sha1-perl Depends?
Thanks in advance.
Bests,
Salvatore
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
diff -urN syslinux-4.03+dfsg.orig//utils/sha1pass syslinux-4.03+dfsg/utils/sha1pass
--- syslinux-4.03+dfsg.orig//utils/sha1pass 2010-10-20 21:25:38.000000000 +0200
+++ syslinux-4.03+dfsg/utils/sha1pass 2011-05-06 09:27:43.921749857 +0200
@@ -1,7 +1,7 @@
#!/usr/bin/perl
use bytes;
-use Digest::SHA1;
+use Digest::SHA;
use MIME::Base64;
sub random_bytes($) {
@@ -29,6 +29,6 @@
unless (defined($salt)) {
$salt = MIME::Base64::encode(random_bytes(6), '');
}
-$pass = Digest::SHA1::sha1_base64($salt, $pass);
+$pass = Digest::SHA::sha1_base64($salt, $pass);
print '$4$', $salt, '$', $pass, "\$\n";
