Hello, On pirmadienis 09 Gegužė 2011 12:48:35 Jonathan Nieder wrote: > Bill Allombert wrote: > > Hello Dpkg maintainers, > > > > Could you fix this issue soon so that it does not interfer with the > > release of Wheezy ? > > Sounds good to me. Raphaël, Joey, any thoughts? > > -- >8 -- > Subject: dpkg-buildpackage: do not export build flags > > For over 10 years policy has required packages to set compiler flags > such as CFLAGS based on settings in DEB_BUILD_OPTIONS, not the values > inherited from dpkg-buildpackage. Stop exporting such variables from > dpkg-buildpackage, so packages relying on the exported variables can > be caught early in the wheezy release cycle and we can be sure > packages build correctly when using debian/rules directly.
All examples of "minimal" dh rules have been recommending contrary all this time. Many packages will be broken unless this is dealt with in dh. Personally, I don't see why this can't be fixed in dh at new compat level (with an dh option to disable this auto-export of buildflags). 99,9% of packages will have to use dpkg-buildflags anyway so it is just pointless to have $(dpkg-buildflags --export=make) in each and every minimal dh rules file. > (Often a good way to set CFLAGS reasonably is with makefile snippets > like "CFLAGS := -Wall $(dpkg-buildflags --get CFLAGS)".) I don't think this scales well. Something like $(dpkg-buildflags -- export=make) would be better to suggest. IMHO, project shall decide on clear recommendations how to proceed. -- Modestas Vainius <mo...@debian.org>
signature.asc
Description: This is a digitally signed message part.
