Hi Stephen, Stephen Kitt wrote:
> --- upstream.orig/binutils/ChangeLog-2008 2011-04-19 10:03:32.000000000 > +0200 > +++ upstream/binutils/ChangeLog-2008 2011-05-25 23:42:44.690507773 +0200 > @@ -840,8 +840,8 @@ > PR binutils/55326 > * bucomm.c (list_supported_architectures): Free architecture list > after use. > - * windres.c (set_endianess): Likewise. > - * windmc.c (set_endianess): Likewise. > + * windres.c (set_endianness): Likewise. > + * windmc.c (set_endianness): Likewise. Thanks. The above (and analogous in other changelog) changes do not seem right --- since the function was historically called set_endianess (sic), I'd think the changelog should use the old name. If I were doing it, I think I'd split this into a few patches: - first user-visible messages - then comments - then code changes (variable and function names) and send them to [email protected] for comments. That way, it would be easier for upstream to take the simplest and most interesting ones quickly and to review the rest easily, too. Hope that helps, Jonathan -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
