On Thu, Sep 08, 2005 at 10:15:29AM +0200, Andreas Jochens wrote:
> On 05-Sep-08 09:43, Christoph Martin wrote:
> > Hi Andreas,

> > I am working on fixing this.
> > I understand the first patch but not the second one?

> > Why do you have to change this?

> > > diff -urN ../tmp-orig/gtalk-0.99.10/src/gtalkd/gtd_disp.c 
> > > ./src/gtalkd/gtd_disp.c
> > > --- ../tmp-orig/gtalk-0.99.10/src/gtalkd/gtd_disp.c       1998-03-20 
> > > 00:10:58.000000000 +0100
> > > +++ ./src/gtalkd/gtd_disp.c       2004-12-22 23:33:02.222413320 +0100
> > > @@ -49,7 +49,7 @@
> > >  #include "gtalklib.h"
> > >  #include "gtalkd.h"

> > > -static int syslogdebug = FALSE;
> > > +int syslogdebug = FALSE;
> > >  static int initialized = FALSE;

> In src/lib/gtalklib.h there is the declaration 'extern int syslogdebug;'.

> It is not possible to declare an 'extern' variable as 'static'.
> So either the 'extern int syslogdebug;' declaration has to be
> removed, or the 'static' has to be removed from the definition.

And there is almost never a reason, in the case where these conflict, to
actually do the latter.  If the variable was declared static, it didn't
need to be exported before, so why export it now?

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
[EMAIL PROTECTED]                                   http://www.debian.org/

Attachment: signature.asc
Description: Digital signature

Reply via email to