tag 627179 + moreinfo tag 627179 - patch quit On Wed, 18 May 2011 15:09:44 +0200 David Kuehling <dvdkh...@gmx.de> wrote:
> the attached patch (mostly) fixes bug #627179 [1]. Patch is against > multistrap SVN head [2]. The patch looks interesting but incomplete and possibly misleading. > The patch misses one occurence of the bug, when multistrap looks at > var/lib/dpkg/status looking for Source: headers only (ignoring Version: > and Package:). Fixing that feels like beyond my perl skills, and I'm > not sure that this whole part is required anyways (it's redandant with > checking the downloaded .debs). For now I put a big Todo: comment on > top. Think about this more carefully. The situation is that multistrap is stateless and something can have happened which means that the run when the packages are actually downloaded failed at a later stage (e.g. in the hooks or setupscript) and then got fixed. So a later run of multistrap still needs to go through the status file (because the .debs have been unpacked and deleted) to check if some source packages still need to be downloaded. apt-get install will check the status file and report that it the packages are already at the newest version, without downloading anything, so the list has to come from somewhere else. i.e. the list of downloaded debs is untrustworthy and must be regarded as incomplete. > That said, for me the patch fixes the problem with missing sources for > the multistrap.conf I test with. More testing required. I hope to get some time to look at this soon but it needs a lot more thought. > The patch also fixes another bug, not yet reported: multistrap could > have fetched source packages versions that differ from the binary > package versions. That is more about differences in aptsources and debootstrap lines than anything to do with specifying the version. I don't think your patch actually works here. apt-get source will get the latest, just as apt-get install will get the latest. What changes is whether the call is made when aptsources are active or when bootstrap sources are active. It needs to be bootstrap sources. I'd need to have a real example of where apt-get install will download a different version to what apt-get source will download for the same sources - that would be a bug in apt, not multistrap. (Multistrap creates deb-src lines for each source specified, so the versions are expected to be the same from deb to deb-src or else there are problems with the archive.) -- Neil Williams ============= http://www.linux.codehelp.co.uk/
pgpcdlbc4gyjk.pgp
Description: PGP signature
