tags 630315 + patch
thanks

It seems there is an indentation issue involved here. The window is now close 
only when save-roster-position is set in the configuration.

Also I wonder whever it's normal save-roster-position is not part of the 
configuration, so it's considered unset and its value can't be changed from the 
advanced settings (I didn't find out how to add a configuration setting).

Attached is a debdiff fixing the bug.

Best regards.
diff -Nru gajim-0.14.2/debian/changelog gajim-0.14.2/debian/changelog
--- gajim-0.14.2/debian/changelog	2011-06-07 19:35:06.000000000 +0200
+++ gajim-0.14.2/debian/changelog	2011-06-14 15:17:18.000000000 +0200
@@ -1,3 +1,10 @@
+gajim (0.14.2-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fix roster closing when save-roster-position unset. Closes: #630315
+
+ -- Thomas Preud'homme <robo...@celest.fr>  Tue, 14 Jun 2011 15:17:11 +0200
+
 gajim (0.14.2-1) unstable; urgency=low
 
   * New upstream release.
diff -Nru gajim-0.14.2/debian/patches/630315_Fix_roster_closing.diff gajim-0.14.2/debian/patches/630315_Fix_roster_closing.diff
--- gajim-0.14.2/debian/patches/630315_Fix_roster_closing.diff	1970-01-01 01:00:00.000000000 +0100
+++ gajim-0.14.2/debian/patches/630315_Fix_roster_closing.diff	2011-06-14 15:31:37.000000000 +0200
@@ -0,0 +1,26 @@
+From: Thomas Preud'homme <robo...@celest.fr>
+Subject: Fix roster closing when save-roster-position unset.
+
+With version 0.14.2 of gajim, roster window is now closed when asked only if
+save-roster-position is set in the preferences because the indentation is wrong.
+This patch fix the indentation to close the roster when asked, wherever
+save-roster-position is set or not.
+
+Origin: vendor
+Bug: http://trac.gajim.org/ticket/6909
+Bug-Debian: http://bugs.debian.org/630315
+Forwarded: no
+Last-Update: 2011-06-14
+---
+
+--- gajim-0.14.2.orig/src/roster_window.py
++++ gajim-0.14.2/src/roster_window.py
+@@ -2300,7 +2300,7 @@ class RosterWindow:
+                 x, y = self.window.get_position()
+                 gajim.config.set('roster_x-position', x)
+                 gajim.config.set('roster_y-position', y)
+-                self.window.hide()
++            self.window.hide()
+         elif gajim.config.get('quit_on_roster_x_button'):
+             self.on_quit_request()
+         else:
diff -Nru gajim-0.14.2/debian/patches/series gajim-0.14.2/debian/patches/series
--- gajim-0.14.2/debian/patches/series	2011-06-07 19:30:18.000000000 +0200
+++ gajim-0.14.2/debian/patches/series	2011-06-14 15:15:32.000000000 +0200
@@ -1,2 +1,3 @@
 00_debian-copying.diff
 01_configure-ac.diff
+630315_Fix_roster_closing.diff

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to