On Thu, 2011-07-14 at 10:01 +0200, Takashi Iwai wrote: > [I resend this again since it didn't get out due to domain problem of > alsa-project.org. If you've already seen the mail, please disregard.] > > At Thu, 14 Jul 2011 03:07:51 +0100, > Ben Hutchings wrote: > > > > The default behaviour should be the same as before this feature > > was introduced, to avoid user confusion. > > > > Reported-by: Toni Mueller <supp...@oeko.net> > > References: http://bugs.debian.org/631963 > > Signed-off-by: Ben Hutchings <b...@decadent.org.uk> > > --- > > The code is rather inconsistent in whether 'mode' means the behaviour or > > mechanism of automute. I didn't touch that but you might want to > > consider some renaming. > > Sorry, I can't take this. > > First, the fix is touching a wrong place. There are several flags to > control the auto-mute behavior. spec->automute is a flag to control > the all auto-mute feature including the headphone jack. For the > line-out jack, it's spec->automute_lines flag.
OK. > Secondly, this is a fix of long-standing bug. With this change, the > driver finally behaves consistently in a way seen in other OS. [...] But why would Linux users know or care how it behaves in the other OS? Ben. -- Ben Hutchings If the facts do not conform to your theory, they must be disposed of.
signature.asc
Description: This is a digitally signed message part
