On Tue, Aug 02, 2011 at 07:07:21PM +0200, Luk Claes wrote: > Including full quote as submitter was not Cc-ed.
Thanks. I hate that part about the BTS.
> > Is there some particular reason why the simple
> > while loop tests
> >
> > while (count-- > 0) {
[...]
> width and cound are both unsigned, so it's not so much an issue that
> they become negative, but rather way too large.
Indeed. I would feel safer with for (i = 0; i < count; i++) here. But see
below.
> > Would
> > width = abs(misc_screen_width());
> > and
> > count = abs(width * gauge->value / 100);
> > improve robustness?
I decided not to fix the progress bar but to lobotomize it because it doesn't
have ANY added value, and who knows what other corner case is lurking in that
code. The rotating line combined with a numeric percentage are enough to
indicate progress, and don't need any loops or tricky arithmetic, and even if
the arithmetic is wrong it will only mess up the display a bit, not the whole
fsck.
> PS2: Should this bug not be tagged lfs?
No, this has nothing to do with large file support.
--
Met vriendelijke groet / with kind regards,
Guus Sliepen <g...@debian.org>
signature.asc
Description: Digital signature
